-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ParentRef wording #1594
Update ParentRef wording #1594
Conversation
I didn't update the v1alpha2 docs; happy to if we think that's worthwhile for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @youngnick!
Rebased and updated, PTAL. |
Thanks @youngnick! LGTM once tests pass. |
apis/v1alpha2/shared_types.go
Outdated
// Note that for ParentRefs that cross namespace boundaries, there are specific | ||
// rules. Cross-namespace references are only valid if they are explicitly | ||
// allowed by something in the namespace they are referring to. For example, | ||
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a | ||
// generic way to enable any other kind of cross-namespace reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Note that for ParentRefs that cross namespace boundaries, there are specific | |
// rules. Cross-namespace references are only valid if they are explicitly | |
// allowed by something in the namespace they are referring to. For example, | |
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a | |
// generic way to enable any other kind of cross-namespace reference. | |
// Note that for ParentRefs that cross namespace boundaries there are specific | |
// rules. Cross-namespace references are only valid if they are explicitly | |
// allowed by something in the namespace they are referring to. For example: | |
// Gateway has the AllowedRoutes field, and ReferenceGrant provides a | |
// generic way to enable any other kind of cross-namespace reference. |
5e072be
to
f11a606
Compare
…ceGrant Signed-off-by: Nick Young <nick@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Notes that ParentRefs that cross namespace boundaries must have some way for the referent to accept/allow the routes.
Which issue(s) this PR fixes:
Fixes #973
Does this PR introduce a user-facing change?: